feat: widen withResource to Resource beyond ResourceRef#301
feat: widen withResource to Resource beyond ResourceRef#301michael-small wants to merge 7 commits into
withResource to Resource beyond ResourceRef#301Conversation
| withProps, | ||
| } from '@ngrx/signals'; | ||
|
|
||
| // TODO - add other specifics of HttpResourceRef (headers, statusCode, progress) |
There was a problem hiding this comment.
Should this be done in this PR? Or a separate PR?
I will already have a separate PR for exposing snapshot as we discussed in a different PR
There was a problem hiding this comment.
I would really prefer is we could this an a separate, as I would also see this is a more generic feature. For example it should also allow to expose resource types which we aren't even aware of.
|
Draft again: need to make the |
michael-small
requested review from
rainerhahnekamp
and removed request for
rainerhahnekamp
rainerhahnekamp
left a comment
rainerhahnekamp
left a comment
There was a problem hiding this comment.
I think we should the generic resource feature (see comments) in a separate issue
| withProps, | ||
| } from '@ngrx/signals'; | ||
|
|
||
| // TODO - add other specifics of HttpResourceRef (headers, statusCode, progress) |
There was a problem hiding this comment.
I would really prefer is we could this an a separate, as I would also see this is a more generic feature. For example it should also allow to expose resource types which we aren't even aware of.
michael-small
force-pushed
the
feat-withResource-take-Resource-type
branch
from
71fc0f6 to
b94e490
Compare
|
@rainerhahnekamp I have to make some changes so that |
|
Provided the following method in a new branch for |
2 participants
Issue: #292